[py23] fix inconsistency of built-in round on Python 3.5 if second argument is None #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 2, 2016 12:15
…nconsistent behaviour between floats/ints and ndigits=None
|
Is it common to call round with None? |
|
well, fontMath does. |
adrientetar
reviewed
Dec 2, 2016
| if sys.version_info[:2] >= (3, 6): | ||
| # in Python 3.6, 'round3' is an alias to the built-in 'round' | ||
| round = round3 = round | ||
| else: |
There was a problem hiding this comment.
Looking at https://bugs.python.org/issue27936 it seems the issue only affects 3.5 (right?) so you could do if sys.version_info[:2] == (3, 5)
There was a problem hiding this comment.
Python 3.3 and 3.4 give the same error.
anthrotype
pushed a commit
to robotools/fontMath
that referenced
this pull request
Dec 4, 2016
…as the pure-python backport already accepts a second None argument It is only the built-in round() in Python 3.x (< 3.6) that has that inconsistent behavior (fonttols round3 is an alias of the built-in round in Python 3), not the pure-python round3 backport used on Python 2.7. Note that the current fonttools HEAD contains the same workaround: fonttools/fonttools#757 We don't want to duplicate it here, so we shall drop this and update fontMath's minimum fonttools requirement as soon as a new version of fonttools is out, which is very soon.
anthrotype
pushed a commit
to robotools/fontMath
that referenced
this pull request
Dec 13, 2016
…optional second None argument fonttools/fonttools#757
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This round thing is killing me..
There's a problem with the built-in
round()function on Python 3.5.If one passes
Noneas a second argument, and the first argument is a float, everything is okBut if the first argument is an integer and you pass None as second argument, it raises:
Now, this happens to be a known issue (https://bugs.python.org/issue27936) which has been fixed in Python 3.6.
Here, on Python3 below 3.6, I have to wrap the built-in round() so that when it gets None as second argument, it behaves as if one did not provide the second argument at all.
See also robotools/fontMath#37 (comment)