[cu2qu] handle case when all points in cubic segments are equal #3904
+27
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, note that kurbo also has this quirk, so merging this will actually break a bunch of diffs. I'll open an issue there to discuss. |
I am getting a weird error: call to undeclared function 'None'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] I'll isolate this with a reproducer and file a bug upstream but for now this works
probably because kurbo's cu2qu code is a port of fonttools |
…-quad approximation apply's Behdad's suggestion here: linebender/kurbo#484 (comment)
anthrotype
added a commit
to linebender/kurbo
that referenced
this pull request
Aug 18, 2025
…o a line or point Fixes #484 intended to match fonttools/fonttools#3904 Note the above fonttools PR only handles 3 to 4 consecutive cubic control points, whereas in here I also consider intersections when a point is collinear and lies in between the other two.
anthrotype
added a commit
to linebender/kurbo
that referenced
this pull request
Aug 18, 2025
…o a line or point Fixes #484 intended to match fonttools/fonttools#3904 Note the above fonttools PR only handles 3 to 4 consecutive cubic control points, whereas in here I also consider intersections when a point is collinear and lies in between the other two.
github-merge-queue bot
pushed a commit
to linebender/kurbo
that referenced
this pull request
Aug 18, 2025
…o a line or single point (#485) Fixes #484 This is intended to match fonttools/fonttools#3904 ~~In addition to the above fonttools PR which only handles 3 to 4 consecutive cubic control points, in here I also consider intersections when a point is collinear and lies in between the endpoints of the other line. I think this is a logical consequence if we agree that when there are 3 consecutive equal points at the front/back of cubic bezier then there's an intersection at the common (start/end) point.~~ ~~kurbo's `try_approx_quadratic` uses `Line::crossing_point` method, so I modified that one to behave like that~~.
|
@cmyr I'm not going to rush releasing a new fonttools with this given it's relatively minor. But when we do push this, we'll have to concurrently do kurbo as well |
flaviotore
added a commit
to flaviotore/kurbo
that referenced
this pull request
Oct 9, 2025
…o a line or single point (#485) Fixes linebender/kurbo#484 This is intended to match fonttools/fonttools#3904 ~~In addition to the above fonttools PR which only handles 3 to 4 consecutive cubic control points, in here I also consider intersections when a point is collinear and lies in between the endpoints of the other line. I think this is a logical consequence if we agree that when there are 3 consecutive equal points at the front/back of cubic bezier then there's an intersection at the common (start/end) point.~~ ~~kurbo's `try_approx_quadratic` uses `Line::crossing_point` method, so I modified that one to behave like that~~.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3903 and supersedes it
I applied behdad's suggestion