Fix UDP port conflict during NAT holepunching on macOS #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
Fixes #16 - UDP port conflict during NAT holepunching on macOS
This PR resolves a race condition where the holepunch goroutine was still holding a UDP port when WireGuard attempted to bind to it, causing "address already in use" errors and forcing unnecessary fallbacks to relay mode.
The fix increases the delay after
close(stopHolepunch)from 10ms to 500ms inmain.go, giving macOS sufficient time to release the UDP port before WireGuard initialization.How to test?
Run olm with holepunch enabled on macOS:
Check the logs - you should see successful connection without port errors:
Verify direct connection (not relay) with:
The endpoint should show the peer's actual IP (e.g.,
1.2.3.4:65456) not the relay server IP.Without this fix, you would see: