A11y: fixed aria-current for entry titles #1141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Sep 30, 2019
jtojnar
reviewed
Sep 30, 2019
jtojnar
reviewed
Sep 30, 2019
jtojnar
reviewed
Sep 30, 2019
|
Oh, ok, it's great then, but those keys are not working and even
screen reader is not announcing them.
seems that I'll have to look at it as well then. :-(
…On 10/1/19, Jan Tojnar ***@***.***> wrote:
jtojnar commented on this pull request.
> @@ -176,13 +176,13 @@ selfoss.ui = {
entrySelect: function(entry) {
if (selfoss.ui.selectedEntry !== null) {
selfoss.ui.selectedEntry.removeClass('selected');
- selfoss.ui.selectedEntry.attr('aria-current', 'false');
+ $('.entry-title > .entry-title-link', entry).attr('aria-current',
'false');
> Now, even though I'm collapsing the entry, Screen reader is still
> announcing 'current' for the entry.
That is correct behaviour. The last entry you interacted with will be
selected (visually, there is a darker border around it). Entry being
selected means you can use selfoss keyboard shorcuts to expand it again
(<kbd>o</kbd>), open the link (<kbd>v</kbd>), or switch to a previous or
next entry (<kbd>j</kbd> and <kbd>k</kbd>, or arrow keys).
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#1141 (comment)
|
|
Hmm, I thought I tested that edge case but apparently not. Will push a fix shortly. |
It was placed to entries instead of the titles it was supposed to be on.
We would attempt to deactivate previous entries, which were null.
When deactivating an entry, we would click its title to collapse it. But when it was already collapsed, the click would reopen it.
Previously, they would throw error
|
Is this good to go? |
|
Rebased onto master for clean git history. |
Yes, it is fine now, but still the keys are not being identified by the screen readers, I feel that I'll have to look deep down into it and will have to manually expose the commands by some methods. But as of now, we can leave it aside for future. |
|
Yeah, they are not very visible for sighted users either. User will either already know the keyboard shortcuts from Google Reader, which we inherited, or read about them on the web page. We should add a help overlay when pressing h. Not sure how to expose the shortcuts to visually impaired users other than adding buttons for every action there is a shortcut for, and putting |
|
I think that something is better than nothing.
Although the user will have to remember all the shortcuts, but
eventually they will be able to become habitual to these shortcuts.
using aria-keyshortcuts is a good idea indeed.
But implementing overlay will be tricky I feel
…On 10/3/19, Jan Tojnar ***@***.***> wrote:
Yeah, they are not very visible for sighted users either. User will either
already know the keyboard shortcuts from Google Reader, which we inherited,
or read about them on the web page. We should add a [help
overlay](#1143) when pressing
<kbd>h</kbd>.
Not sure how to expose the shortcuts to visually impaired users other than
adding buttons for every action there is a shortcut for, and putting
`aria-keyshortcuts` to that. But I am not sure how usable it would be with
the 22 shortcuts selfoss currently supports.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#1141 (comment)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed aria-current for entry titles.
Previously the aria-current was getting applied to the whole entry.