Fix release, make sure it's tested on PRs too #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nficca since this is a very low impact change i'm just going to merge but feel free to review and comment, if you do i'll address them after the fact |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes an issue in the release process where tags were not fetched during the release, preventing the release from being able to generate changelogs.
This also updates the release process to run a "dry run" on PRs so that any issues like this can be caught earlier in the future.
Acceptance criteria
The release process can now generate changelogs.
Testing plan
Validated CI run manually: https://github.com/fossas/circe/actions/runs/13773797629/job/38518509098
Metrics
None
Risks
No risk
References
None
Checklist