feat (buck all targets) add option to specify a target such as //third-party/... #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Mar 27, 2019
buildtools/buck/buck.go
Outdated
| if err != nil { | ||
| return transitiveDeps, err | ||
|
|
||
| allDependencies := []string{} |
There was a problem hiding this comment.
ineffectual assignment to allDependencies (from ineffassign)
buildtools/buck/buck.go
Outdated
| deps, err := cmdAudit(b.Cmd, "dependencies", b.Target) | ||
| if err != nil { | ||
| return imports, err | ||
| directDeps := []string{} |
There was a problem hiding this comment.
ineffectual assignment to directDeps (from ineffassign)
06c083f to
cf4819c
Compare
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
==========================================
+ Coverage 45.84% 46.28% +0.43%
==========================================
Files 81 81
Lines 4234 4291 +57
==========================================
+ Hits 1941 1986 +45
- Misses 2110 2116 +6
- Partials 183 189 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an incremental feature to buck support to enable more accurate scanning.