Fix cargo workspace members showing as deps #1600
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The graph of a cargo project incorrectly reported workspace member packages as dependencies when they are not really dependencies so much as what is being scanned.
From a UI perspective, this was actually fixed by #1599 since the workspace members are all path dependencies and so get filtered already. But the project graph was still technically incorrect so this resolves that.
Acceptance criteria
Packages defined in a Cargo workspace are not reported as dependencies.
Testing plan
164eae5e76cc3b17bd9d59f647e62b5b9b10785c. Runfossa analyzeand confirm that generated graph is empty in the output json and that no dependencies are displayed in the UI.pruneUnreachablewhich we can now remove.Risks
Metrics
References
Cargoanalyzer reports library project as dependency of itselfChecklist
docs/.docs/README.msand gave consideration to how discoverable or not my documentation is.Changelog.md. If this PR did not mark a release, I added my changes into an## Unreleasedsection at the top..fossa.ymlorfossa-deps.{json.yml}, I updateddocs/references/files/*.schema.jsonAND I have updated example files used byfossa initcommand. You may also need to update these if you have added/removed new dependency type (e.g.pip) or analysis target type (e.g.poetry).docs/references/subcommands/<subcommand>.md.