Article ellipses Open in Browser Support#22642
Closed
mikeydorje wants to merge 1 commit intoforem:mainfrom
Closed
Conversation
Contributor
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
4bd3d04 to
9b6bd01
Compare
benhalpern
requested changes
Dec 2, 2025
Contributor
benhalpern
left a comment
There was a problem hiding this comment.
This actually won't work because due to caching we won't always know on the server side what the request's user agent is because we cache across all responses. We must add this dynamically via javascript on the frontend.
Contributor
Author
|
@benhalpern The other version is better anyway I think: https://github.com/forem/app/pull/83 This one would be in the article view only, not in an external webpage, which is the idea. |
Contributor
Author
|
Other solution is better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Add "Open in Browser" link to article dropdown for mobile app
Adds conditional link in article actions dropdown that only appears when accessed from ForemWebView mobile app. Allows users to open articles in their external browser.
Changes:
Related Tickets & Documents
App counterpart: https://github.com/forem/app/pull/84
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
UI accessibility checklist
If your PR includes UI changes, please utilize this checklist:
CriticalandSeriousissues?For more info, check out the
Forem Accessibility Docs.
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
have not been included
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?