Add missing Flush() method #1039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a missing Flush() method to the GzipResponseWriter to ensure proper flushing of gzip-compressed and HTTP responses.
- Added a new Flush() method that calls both the gzip writer's Flush() and, if available, the underlying ResponseWriter's Flush().
- Addresses issue #1038 by extending the flusher interface implementation.
Comments suppressed due to low confidence (1)
fhttp/http_utils.go:529
- Consider adding tests for the Flush() method to confirm that both the gzip writer and the underlying ResponseWriter (if it implements http.Flusher) are flushed properly.
// Flush so this is a flusher.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1039 +/- ##
======================================
Coverage 74.0% 74.0%
======================================
Files 26 26
Lines 6398 6403 +5
======================================
+ Hits 4736 4741 +5
Misses 1477 1477
Partials 185 185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
asha-oss
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1038
Note tested with h2life but would be better to test... here tooAdded test