Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix BrokenPipeError handling in rdump #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2025
Merged

Fix BrokenPipeError handling in rdump #188

merged 1 commit into from
Oct 13, 2025

Conversation

@yunzheng
Copy link
Member

Fixes #186

@codecov
Copy link

codecov bot commented Aug 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.38%. Comparing base (f2606d1) to head (3964b57).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
flow/record/tools/rdump.py 71.42% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
+ Coverage   83.32%   83.38%   +0.05%     
==========================================
  Files          35       35              
  Lines        3713     3707       -6     
==========================================
- Hits         3094     3091       -3     
+ Misses        619      616       -3
Flag Coverage Δ
unittests 83.38% <71.42%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yunzheng
Copy link
Member Author

@JSCU-CNI can you also check if this PR works for you regarding Elastic search exceptions? as I basically reverted the RecordWriter back to a with statement that was removed in this commit: c482853

Schamper
Schamper previously requested changes Aug 20, 2025
View reviewed changes
@yunzheng yunzheng force-pushed the bugfix/rdump-catch-sigpipe branch 2 times, most recently from f9f2f12 to b504827 Compare August 21, 2025 15:35
@yunzheng yunzheng force-pushed the bugfix/rdump-catch-sigpipe branch from b504827 to 21d6b62 Compare September 8, 2025 13:53
@yunzheng yunzheng requested a review from Schamper September 8, 2025 14:17
@JSCU-CNI
Copy link
Contributor

JSCU-CNI commented Sep 8, 2025

@JSCU-CNI can you also check if this PR works for you regarding Elastic search exceptions? as I basically reverted the RecordWriter back to a with statement that was removed in this commit: c482853

I need more time to test this, but I think the existing elastic tests should catch any breaking changes.

@yunzheng yunzheng force-pushed the bugfix/rdump-catch-sigpipe branch from 21d6b62 to 3964b57 Compare October 13, 2025 12:39
@yunzheng
Copy link
Member Author

@JSCU-CNI can you also check if this PR works for you regarding Elastic search exceptions? as I basically reverted the RecordWriter back to a with statement that was removed in this commit: c482853

I need more time to test this, but I think the existing elastic tests should catch any breaking changes.

i'll go ahead and merge this, if any issues pop up, please raise a new issue.

@yunzheng yunzheng requested a review from Horofic October 13, 2025 14:17
@yunzheng yunzheng merged commit e5a9f56 into main Oct 13, 2025
20 of 23 checks passed
@yunzheng yunzheng deleted the bugfix/rdump-catch-sigpipe branch October 13, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Horofic Horofic Horofic approved these changes

@Schamper Schamper Awaiting requested review from Schamper

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@catch_sigpipe decorator not working in rdump

5 participants

@yunzheng @JSCU-CNI @Schamper @Horofic