Remove internal/client package #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor server_test.go to be independent from internal/client package and less brittle by avoiding sting comparison in favour of comparing map values for certain keys for header and trailers. In a follow up commit we will upgrade protoc-gen-go and libraries which made these tests fail, so we are fixing them first and independently.
Remove client package now that server_test.go doesn't depend on it anymore. Roughly include it in cmd/client/main.go, as private methods on config/cli struct type.
camh-
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor server_test.go to be independent from internal/client package and
less brittle by avoiding sting comparison in favour of comparing map values
for certain keys for headers and trailers. In a follow up commit we will
upgrade protoc-gen-go and libraries which made these tests fail, so we are
fixing them first and independently.
Remove client package once server_test.go doesn't depend on it anymore. Roughly
include it in cmd/client/main.go, as private methods on config/cli struct
type.