test: Fix data race #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix data race in go tests detected by Go's race detector. When investigating a spurious CI failure in the tests, we found that `NewTestServer()` in combination with test server method `SetHTTPHandler` causes a race as reported by the detector: WARNING: DATA RACE Read at 0x00c000354220 by goroutine 10: foxygo.at/jig/serve.(*Server).Serve() /Users/julia/Development/jig/serve/server.go:102 +0x208 foxygo.at/jig/serve.(*TestServer).Start.func1() /Users/julia/Development/jig/serve/server.go:269 +0x50 Previous write at 0x00c000354220 by goroutine 7: foxygo.at/jig/serve.(*Server).SetHTTPHandler() /Users/julia/Development/jig/serve/server.go:96 +0x1ec foxygo.at/jig/serve/httprule.TestHTTP() /Users/julia/Development/jig/serve/httprule/handler_test.go:29 +0x1dc Fix by using `NewUnstartedTestServer` and explicitly and synchronously calling `Start` method after calling `SetHTTPHandler`. Add the `-race` flag in Makefile to Go test execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix data race in go tests detected by Go's race detector. When investigating a
spurious CI failure in the tests, we found that
NewTestServer()in combinationwith test server method
SetHTTPHandlercauses a race as reported by thedetector:
Fix by using
NewUnstartedTestServerand explicitly and synchronously callingStartmethod after callingSetHTTPHandler.Add the
-raceflag in Makefile to Go test execution.