Thanks to visit codestin.com
Credit goes to github.com

Skip to content

housekeeping: Complete previous fixups #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 6, 2025
Merged

housekeeping: Complete previous fixups #53

merged 2 commits into from
Feb 6, 2025

Conversation

@juliaogris
Copy link
Member

@juliaogris juliaogris commented Feb 6, 2025 •
edited
Loading

Complete previous fixups removing deprecated calls to httprule.NewServer and
avoiding data races by calling server.NewUnstartedTestServer.

I AM NOT SORRY

@juliaogris
test: Fix data race
63a49b1 
We missed one data race in a recent commit that only showed up with an upgraded
Go toolchain, to be added in a follow-up commit.

Commit: 3abeb72
@juliaogris
httprule: Use NewHandler, not deprecated NewServer
c4a69e7 
Use httprule.NewHandler, not the deprecated httprule.NewServer in main_test.go.
This was an oversight in the previous commit.

Commit: 388f73b
camh-
camh- approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@camh- camh- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥦 Thank you, @'not sorry'

@juliaogris juliaogris merged commit e467f84 into master Feb 6, 2025
2 checks passed
@juliaogris juliaogris deleted the leftovers branch February 6, 2025 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camh- camh- camh- approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juliaogris @camh-