refactor: load no more spawn a task in read runtime. #1073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since some engine doesn't rely on it. Signed-off-by: MrCroxx <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
3f7f53f to
c009129
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since some engine doesn't rely on it.
What's changed and what's your intention?
There is no need to spawn a task since IO engine already handles it.
Need to run e2e benchmark with RW to see if this refactoring increases the latency.
Checklist
cargo x(orcargo x --fastinstead if the old tests are not modified) in my local environment.Related issues or PRs (optional)