Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: mitigate low-pri errors, refine errors #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

refactor: mitigate low-pri errors, refine errors #906

merged 1 commit into from
Mar 26, 2025

Conversation

@MrCroxx
Copy link
Member

@MrCroxx MrCroxx commented Mar 26, 2025

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

mitigate #905

@MrCroxx MrCroxx added this to the v0.15 milestone Mar 26, 2025
@MrCroxx MrCroxx self-assigned this Mar 26, 2025
@MrCroxx MrCroxx mentioned this pull request Mar 26, 2025
Closed
@codecov
Copy link

codecov bot commented Mar 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 54.16667% with 33 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-storage/src/large/generic.rs 13.63% 19 Missing ⚠️
foyer-storage/src/device/direct_file.rs 71.42% 8 Missing ⚠️
foyer-storage/src/device/direct_fs.rs 72.72% 6 Missing ⚠️
Files with missing lines Coverage Δ
foyer-storage/src/error.rs 0.00% <ø> (ø)
foyer-storage/src/device/direct_fs.rs 87.11% <72.72%> (+0.37%) ⬆️
foyer-storage/src/device/direct_file.rs 86.22% <71.42%> (+0.34%) ⬆️
foyer-storage/src/large/generic.rs 85.95% <13.63%> (-3.22%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrCroxx MrCroxx merged commit d042d56 into main Mar 26, 2025
35 checks passed
@MrCroxx MrCroxx deleted the xx/err branch March 26, 2025 04:23
@wenym1 wenym1 mentioned this pull request Mar 26, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@MrCroxx MrCroxx

Labels

refactor

Projects

foyer - Development Roadmap
Status: Done

Milestone

v0.15

Development

Successfully merging this pull request may close these issues.

1 participant

@MrCroxx