fix: fix split condition calculation error #912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
- Fix blob/region split condition calculation error. - Add ut for the corner case. - Refine splitter code. - Fix direct fs error log. Signed-off-by: MrCroxx <[email protected]>
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
Signed-off-by: MrCroxx <[email protected]>
8 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a blob/region split condition calculation error and refines the logging and splitting logic while adding tests for a corner case.
- Fixes the calculation error by updating how blob and region boundaries are computed.
- Enhances logging by including a flusher identifier across modules.
- Refines the splitter algorithm and adjusts error handling in the direct file system module.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| foyer-storage/src/large/generic.rs | Passes a flusher id to the asynchronous block and updates flusher invocation. |
| foyer-storage/src/large/flusher.rs | Integrates an id parameter into the flusher constructor and logging entries. |
| foyer-storage/src/large/buffer.rs | Refines the blob/region splitting logic and adjusts buffer handling. |
| foyer-storage/src/device/direct_fs.rs | Revises the capacity check and error logging for IO range validation. |
Comments suppressed due to low confidence (1)
foyer-storage/src/device/direct_fs.rs:104
- The variable 'e' is used in the error log and for returning an error but is not defined in this context. Define an appropriate error value or update the check to avoid referencing an undefined variable.
tracing::error!(region, ?e, "[direct fs]: io range out of region capacity");
This was referenced Mar 28, 2025
HammadB
pushed a commit
to chroma-core/chroma
that referenced
this pull request
Apr 17, 2025
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Fix foyer large object disk cache bug by bumping to the latest version. - FYI: foyer-rs/foyer#912 ## Test plan *How are these changes tested?* - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes *Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs repository](https://github.com/chroma-core/docs)?* Signed-off-by: MrCroxx <[email protected]>
Inventrohyder
pushed a commit
to Inventrohyder/chroma
that referenced
this pull request
Aug 5, 2025
…core#4107) ## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Fix foyer large object disk cache bug by bumping to the latest version. - FYI: foyer-rs/foyer#912 ## Test plan *How are these changes tested?* - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes *Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs repository](https://github.com/chroma-core/docs)?* Signed-off-by: MrCroxx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
Checklist
make all(ormake fastinstead if the old tests are not modified) in my local environment.Related issues or PRs (optional)
close #905
risingwavelabs/risingwave#21116
risingwavelabs/risingwave#21157