Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: More fixes (backport #1161) #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2025
Merged

fix: More fixes (backport #1161) #1162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc0ca74
fix: convert to deal modals's convert button
shariquerik Aug 19, 2025
ee8f806
fix: align action buttons in GridFieldsEditorModal
shariquerik Aug 19, 2025
5a243d2
fix: update Dropdown styling in SLASection component
shariquerik Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/Controls/GridFieldsEditorModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
</div>
</template>
<template #actions>
<div class="flex flex-col gap-2">
<div class="flex items-center gap-2 justify-end">
<Button
v-if="dirty"
class="w-full"
Expand Down
19 changes: 6 additions & 13 deletions frontend/src/components/Modals/ConvertToDealModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,5 @@
<template>
<Dialog
v-model="show"
:options="{
size: 'xl',
actions: [
{
label: __('Convert'),
variant: 'solid',
onClick: convertToDeal,
},
],
}"
>
<Dialog v-model="show" :options="{ size: 'xl' }">
<template #body-header>
<div class="mb-6 flex items-center justify-between">
<div>
Expand Down Expand Up @@ -90,6 +78,11 @@
/>
<ErrorMessage class="mt-4" :message="error" />
</template>
<template #actions>
<div class="flex justify-end">
<Button :label="__('Convert')" variant="solid" @click="convertToDeal" />
</div>
</template>
</Dialog>
</template>
<script setup>
Expand Down
7 changes: 2 additions & 5 deletions frontend/src/components/SLASection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,10 @@
<div v-else>{{ s.value }}</div>
</div>
</Tooltip>
<Dropdown
class="form-control"
v-if="s.type == 'Select'"
:options="s.options"
>
<Dropdown v-if="s.type == 'Select'" :options="s.options">
<template #default="{ open }">
<Button
class="form-control bg-surface-white hover:bg-surface-white"
:label="s.value"
:iconRight="open ? 'chevron-up' : 'chevron-down'"
/>
Expand Down