fix: Popup doesn't close after deletion #1192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shariquerik
requested changes
Sep 3, 2025
|
@patleYashpal make sure you don't break indentation and add pre-commit to avoid missing it. |
shariquerik
approved these changes
Sep 3, 2025
shariquerik
added a commit
that referenced
this pull request
Sep 3, 2025
fix: Popup doesn't close after deletion (backport #1192)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes problem related to abnormal behaviour of 2 deletion pop ups. First row selected pop up and second confirm delete pop up does not disappear after successful deletion.
Solves issue #1189
Recording.2025-08-27.001305.mp4