Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: utility method to fetch custom sql functions and procedure #33189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

refactor: utility method to fetch custom sql functions and procedure #33189

merged 1 commit into from
Jul 3, 2025

Conversation

@ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Jul 2, 2025

Screenshot from 2025-07-02 14-33-09
required by: frappe/erpnext#47892

@github-actions github-actions bot added the skip-release-notes This PR should not be mentioned in the release notes label Jul 2, 2025
@ruthra-kumar ruthra-kumar requested a review from ankush July 2, 2025 09:08
@ruthra-kumar ruthra-kumar added backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15 labels Jul 2, 2025
akhilnarang
akhilnarang reviewed Jul 2, 2025
View reviewed changes
Copy link
Member

@akhilnarang akhilnarang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, I think its fine to add in the main database.py (seems like its the same for MariaDB/Postgres?)

@ruthra-kumar ruthra-kumar force-pushed the get_existing_procedures_and_functions branch from 722a67f to 1ceea95 Compare July 2, 2025 11:41
@ruthra-kumar
Copy link
Member Author

ruthra-kumar commented Jul 2, 2025

Seems fine, I think its fine to add in the main database.py (seems like its the same for MariaDB/Postgres?)

Just tested it locally. It's the same for both. Moved it.

@ruthra-kumar ruthra-kumar merged commit f19bd7c into frappe:develop Jul 3, 2025
21 of 22 checks passed
This was referenced Jul 3, 2025
Merged
Merged
ruthra-kumar added a commit that referenced this pull request Jul 3, 2025
@ruthra-kumar
Merge pull request #33202 from frappe/mergify/bp/version-15-hotfix/pr…
123b84d 
…-33189

refactor: utility method to fetch custom sql functions and procedure (backport #33189)
ruthra-kumar added a commit that referenced this pull request Jul 3, 2025
@ruthra-kumar
Merge pull request #33201 from frappe/mergify/bp/version-14-hotfix/pr…
cfe7167 
…-33189

refactor: utility method to fetch custom sql functions and procedure (backport #33189)
@ruthra-kumar ruthra-kumar mentioned this pull request Jul 3, 2025
Merged
1 task
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akhilnarang akhilnarang akhilnarang approved these changes

@ankush ankush Awaiting requested review from ankush

Assignees

No one assigned

Labels

backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15 skip-release-notes This PR should not be mentioned in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ruthra-kumar @akhilnarang