fix: use file_url instead of file_name #1814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@pateljannat Hi, I’m assuming all the resumes that were uploaded are public. |
lms
|
||||||||||||||||||||||||||||||
| Project |
lms
|
| Branch Review |
fix-resume-url
|
| Run status |
|
| Run duration | 00m 59s |
| Commit |
|
| Committer | Rehan Ansari |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
2
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Collaborator
|
@rehanrehman389 make them private through the same patch, and also make sure they are linked to the LMS Job Application Document. Also, the document should then be shared with the job poster so they have access to the resume |
Contributor
Author
Currently, the LMS Student role has read access to the LMS Job Application, so everyone with this role can access the resume. |
…are with job owner
550c7d6 to
a5f9adc
Compare
Collaborator
|
🎉 This PR is included in version 2.40.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.