fix: open dialog directly to create quiz and assignment #1866
Conversation
|
@muhamiyan This fix redirects the users to the list, but since the intention is to create a new quiz or assignment, they still need to click on the Create button. Can we send a query param from the redirectToForm function, such that if this parameter is present then we show the creation dialog directly? |
This reverts commit fc82ec8.
|
thanks @pateljannat, showing the creation dialog is better, I will fix it. |
|
Please to review, thanks @pateljannat |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1866 +/- ##
==========================================
Coverage ? 19.95%
==========================================
Files ? 156
Lines ? 4817
Branches ? 0
==========================================
Hits ? 961
Misses ? 3856
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lms
|
||||||||||||||||||||||||||||||
| Project |
lms
|
| Branch Review |
issues-1
|
| Run status |
|
| Run duration | 01m 05s |
| Commit |
|
| Committer | Apriliansyah Idris |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
2
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
|
🎉 This PR is included in version 2.42.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Bismillah, should be to create a new quiz or new assignment via the add button.
Feature of Quiz and Assignment in courses provides the API endpoints /lms/quizzes/new and /lms/assignments/new so it worked fine, but this no longer works on the latest version of the LMS.