fix: misc issues #1873
Merged
fix: misc issues #1873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pateljannat
commented
Dec 2, 2025
- Users with role Batch Evaluator can now edit batches created by them.
- When a batch is unpublished, the previous logic used to check if the user has a student role, they were redirected to the batch list. But a user may have both student and evaluator role, in which case evaluators were unable to access unpublished batches. Now the logic instead checks if the user is not moderator and not evaluator before redirecting.
- On a new site, signup is disabled by default, but the LMS Settings which controls signup was not disabled. This caused inconsistency in behaviour.
- Job application list only showed the first 20 results and Load More button was missing. Added that.
lms
|
||||||||||||||||||||||||||||||
| Project |
lms
|
| Branch Review |
issues-153
|
| Run status |
|
| Run duration | 00m 55s |
| Commit |
|
| Committer | Jannat Patel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
2
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Collaborator
|
🎉 This PR is included in version 2.41.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.