Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: misc issues #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pateljannat merged 5 commits into from
Dec 10, 2025
Merged

fix: misc issues #1897

pateljannat merged 5 commits into from
Dec 10, 2025

Conversation

@pateljannat
Copy link
Collaborator

@pateljannat pateljannat commented Dec 10, 2025

  1. Validate url's to start with http or https
  2. Improved batch validations

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.97%. Comparing base (1f65439) to head (43efebe).
⚠️ Report is 35 commits behind head on develop.

Files with missing lines Patch % Lines
lms/job/doctype/job_opportunity/job_opportunity.py 0.00% 1 Missing ⚠️
...assignment_submission/lms_assignment_submission.py 0.00% 1 Missing ⚠️
...ctype/lms_batch_enrollment/lms_batch_enrollment.py 0.00% 1 Missing ⚠️
lms/lms/doctype/lms_certificate/lms_certificate.py 66.66% 1 Missing ⚠️
lms/lms/doctype/lms_settings/lms_settings.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1897      +/-   ##
===========================================
+ Coverage    19.95%   19.97%   +0.02%     
===========================================
  Files          156      156              
  Lines         4817     4816       -1     
===========================================
+ Hits           961      962       +1     
+ Misses        3856     3854       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress
Copy link

cypress bot commented Dec 10, 2025

lms    Run #1817

Run Properties:  status check passed Passed #1817  •  git commit ce66c7c229 ℹ️: Merge 43efebe3a7e9b20cdad808d67c031ef2e6062cb7 into 73ee1b2f0956e66e2a73e832857d...
Project lms
Branch Review issues-159
Run status status check passed Passed #1817
Run duration 01m 00s
Commit git commit ce66c7c229 ℹ️: Merge 43efebe3a7e9b20cdad808d67c031ef2e6062cb7 into 73ee1b2f0956e66e2a73e832857d...
Committer Jannat Patel
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 2
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@pateljannat pateljannat merged commit 316e739 into frappe:develop Dec 10, 2025
7 checks passed
@pateljannat pateljannat mentioned this pull request Dec 11, 2025
Closed
@frappe-pr-bot
Copy link
Collaborator

frappe-pr-bot commented Dec 11, 2025

🎉 This PR is included in version 2.42.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pateljannat pateljannat mentioned this pull request Dec 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pateljannat @codecov-commenter @frappe-pr-bot