genl/qer: Only process MBR/GBR when all four attrs exist to avoid null access#153
Merged
tim-ywliu merged 1 commit intofree5gc:masterfrom Sep 12, 2025
Merged
Conversation
tim-ywliu
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Netlink messages may omit some QER MBR/GBR attributes. Accessing
mbr_param_attrs/gbr_param_attrswithout verifying all expected fields risks null access.Changes
nla_parse_nested:GTP5G_QER_MBR_UL_HIGH32GTP5G_QER_MBR_UL_LOW8GTP5G_QER_MBR_DL_HIGH32GTP5G_QER_MBR_DL_LOW8nla_parse_nested:GTP5G_QER_GBR_UL_HIGH32GTP5G_QER_GBR_UL_LOW8GTP5G_QER_GBR_DL_HIGH32GTP5G_QER_GBR_DL_LOW8Behavior Impact
Affected Files
src/genl/genl_qer.c