chore: update go version to 1.24 #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Update project to use Go 1.24, bump related dependencies, and refresh lint and CI configurations.
- Bump Go version in
go.modand workflows to 1.24 and update toolchains/actions. - Update error message formatting in
config.goandserver.go. - Overhaul
.golangci.ymlwith new version, linters, and settings.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/factory/config.go | Lowercased “Invalid” in error wrap for Go 1.24 style consistency |
| internal/sbi/server.go | Adjusted error message text for unsupported scheme |
| internal/sbi/processor/nf_discovery.go | Simplified boolean logic in query parameter validation |
| go.mod | Bump Go version to 1.24; update openapi module version |
| .golangci.yml | Revamped lint config to version 2 syntax and customized rules |
| .github/workflows/golangci-lint.yml | Updated Go matrix and golangci-lint action to v8 |
| .github/workflows/go.yml | Bumped Go matrix to 1.24 |
Comments suppressed due to low confidence (1)
internal/sbi/server.go:133
- [nitpick] Rephrase this error message for clarity and Go conventions, e.g. fmt.Errorf("unsupported scheme [%s]", serverScheme), including a space before the bracket.
err = fmt.Errorf("not support this scheme[%s]", serverScheme)
|
Thanks a lot! |
ianchen0119
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.