Use standard boolean type #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In C23, bool is a new reserved keyword [1], which means that a custom enum cannot be named after it anymore. Replace it with a proper bool type, which fulfills the original purpose of this enum. Because not all compilers support C23 yet, including MSVC and Apple Clang [2], include the compatibility header stdbool.h available since C99 so it builds fine in all platforms. This change is especially relevant because GCC 15 defaults to C23, causing freegish to fail to build [3]. [1] https://gcc.gnu.org/gcc-15/porting_to.html#c23-new-keywords [2] https://en.cppreference.com/w/c/compiler_support/23 [3] https://bugs.debian.org/1096653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In C23, bool is a new reserved keyword [1], which means that a custom enum cannot be named after it anymore. Replace it with a proper bool type, which fulfills the original purpose of this enum.
Because not all compilers support C23 yet, including MSVC and Apple Clang [2], include the compatibility header stdbool.h available since C99 so it builds fine in all platforms.
This change is especially relevant because GCC 15 defaults to C23, causing freegish to fail to build [3].
[1] https://gcc.gnu.org/gcc-15/porting_to.html#c23-new-keywords
[2] https://en.cppreference.com/w/c/compiler_support/23
[3] https://bugs.debian.org/1096653
I don't have a Windows box to test this PR against. I'm assuming it has reasonably recent compilers that support at least C99. I've tested with both GCC 14 and GCC 15, and it builds fine.