Check the capital has neighbouring system (SmokeTestGame) #5163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Why |
5ca40f2 to
3793147
Compare
cause i was confused; fixed |
|
build fails as test works |
|
It's quite unusual that Windows build didn't fail test. |
seems the signals do not get used or propagated correctly; as also the windows CI has the test fail there is the (succesful) parse test afterwards |
Cjkjvfnby
requested changes
Mar 15, 2025
| shell: pwsh | ||
| working-directory: build | ||
| run: | | ||
| $env:FO_CHECKSUM_SPECIES_NAME = "SP_CELESTEPHYTE" |
There was a problem hiding this comment.
Should we create a custom file species that will not be a part of the game and modify it?
For the sake of the parser testing, we could add all possible effects and conditions there. (not in this review)
There was a problem hiding this comment.
As I remember I tried to test crash on parsing and outputting dump.
|
both macos are also succeeding |
|
@agrrr3 MacOS skips Smoke* system tests because it cann't launch server binary. |
|
So we can merge, cant we? |
agrrr3
added a commit
to agrrr3/freeorion
that referenced
this pull request
Mar 19, 2025
… a system Test freeorion#5163 (master should fail with the test but without the fix) Issue freeorion#5158 QA Status: quickfix completely untested the underlying issue why this surfaces is not fixed with this. the underlying issue is that the empire graphs do get cleaned when the generic graph gets cleaned and not rebuild before the AI uses the empire graphs waiting for some comments on what the intended design is
agrrr3
added a commit
to agrrr3/freeorion
that referenced
this pull request
Mar 19, 2025
… a system Test freeorion#5163 (master should fail with the test but without the fix) Issue freeorion#5158 QA Status: quickfix completely untested the underlying issue why this surfaces is not fixed with this. the underlying issue is that the empire graphs do get cleaned when the generic graph gets cleaned and not rebuild before the AI uses the empire graphs waiting for some comments on what the intended design is
|
Shouldn't we merge fix first? |
|
only if it does not break the test ;) (the quickfix currently does; could
not compile/run the tests when i made it)
…On Wed, Mar 19, 2025 at 11:12 AM O01eg ***@***.***> wrote:
Shouldn't we merge fix first?
—
Reply to this email directly, view it on GitHub
<#5163 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYZ6SMKHX7AE7ZXCHBFYQL2VE7KRAVCNFSM6AAAAABZACHPMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZWGAZTMMZRGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: o01eg]*o01eg* left a comment (freeorion/freeorion#5163)
<#5163 (comment)>
Shouldn't we merge fix first?
—
Reply to this email directly, view it on GitHub
<#5163 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYZ6SMKHX7AE7ZXCHBFYQL2VE7KRAVCNFSM6AAAAABZACHPMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZWGAZTMMZRGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
agrrr3
added a commit
to agrrr3/freeorion
that referenced
this pull request
Mar 20, 2025
… a system Test freeorion#5163 (master should fail with the test but without the fix) Issue freeorion#5158 QA Status: quickfix completely untested the underlying issue why this surfaces is not fixed with this. the underlying issue is that the empire graphs do get cleaned when the generic graph gets cleaned and not rebuild before the AI uses the empire graphs waiting for some comments on what the intended design is
|
actually the working quickfix does not make the test complete. and i am not sure how to modify the test in a meaningful way as this is currently a timing issue. |
|
@agrrr3 OK, at least we'll get fix for AI. |
agrrr3
added a commit
that referenced
this pull request
Mar 20, 2025
… a system Test #5163 (master should fail with the test but without the fix) Issue #5158 QA Status: quickfix completely untested the underlying issue why this surfaces is not fixed with this. the underlying issue is that the empire graphs do get cleaned when the generic graph gets cleaned and not rebuild before the AI uses the empire graphs waiting for some comments on what the intended design is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intended to expose #5158