Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Change type of resource.path option to boost::filesystem::path #5198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Change type of resource.path option to boost::filesystem::path #5198

wants to merge 6 commits into from

Conversation

@o01eg
Copy link
Contributor

@o01eg o01eg commented Apr 6, 2025

Should help with #4988

@o01eg o01eg added category:bug The Issue/PR describes or solves a perceived malfunction within the game. component:internal The Issue/PR deals with any project component that has no explicit `component` label. labels Apr 6, 2025
@o01eg o01eg added this to the v0.5.2 Release milestone Apr 6, 2025
@o01eg o01eg requested a review from geoffthemedio April 6, 2025 09:43
@o01eg o01eg self-assigned this Apr 6, 2025
@o01eg o01eg marked this pull request as draft April 6, 2025 09:57
@o01eg o01eg added the status:help wanted Other developers or external contributors are welcome to support developing this Issue/PR. label Apr 6, 2025
geoffthemedio
geoffthemedio reviewed Apr 6, 2025
View reviewed changes
geoffthemedio
geoffthemedio reviewed Apr 6, 2025
View reviewed changes
geoffthemedio
geoffthemedio reviewed Apr 6, 2025
View reviewed changes
geoffthemedio
geoffthemedio reviewed Apr 6, 2025
View reviewed changes
geoffthemedio
geoffthemedio reviewed Apr 6, 2025
View reviewed changes
geoffthemedio
geoffthemedio reviewed Apr 6, 2025
View reviewed changes
geoffthemedio
geoffthemedio reviewed Apr 6, 2025
View reviewed changes
geoffthemedio
geoffthemedio reviewed Apr 6, 2025
View reviewed changes
geoffthemedio
geoffthemedio reviewed Apr 6, 2025
View reviewed changes
test/util/TestPathOptions.cpp
#include "util/i18n.h"
#include "util/XMLDoc.h"

BOOST_AUTO_TEST_SUITE(TestPathOptions);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can probably make the converters sufficiently constexpr to allow compile-time testing as well

@o01eg o01eg force-pushed the oprions-db-path-resource-path branch from 85994fb to c0c5a87 Compare May 23, 2025 19:54
@o01eg o01eg requested a review from geoffthemedio May 23, 2025 19:54
@o01eg o01eg force-pushed the oprions-db-path-resource-path branch from c0c5a87 to 8937183 Compare May 23, 2025 20:07
@o01eg o01eg marked this pull request as ready for review May 24, 2025 03:47
@geoffthemedio
Copy link
Member

I get a lost connection to server when quickstarting with this applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geoffthemedio geoffthemedio Awaiting requested review from geoffthemedio

Assignees

@o01eg o01eg

Labels

category:bug The Issue/PR describes or solves a perceived malfunction within the game. component:internal The Issue/PR deals with any project component that has no explicit `component` label. status:help wanted Other developers or external contributors are welcome to support developing this Issue/PR.

Projects

None yet

Milestone

v0.5.2 Release

Development

Successfully merging this pull request may close these issues.

2 participants

@o01eg @geoffthemedio