Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix: Implemented decimal-to-hh:mm conversion for timezone adjustments #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jevantang merged 1 commit into from
Dec 2, 2024
Merged

Fix: Implemented decimal-to-hh:mm conversion for timezone adjustments #43

jevantang merged 1 commit into from
Dec 2, 2024

Conversation

@ahmadreza1383
Copy link
Contributor

@ahmadreza1383 ahmadreza1383 commented Dec 2, 2024

I found a bug in the project.

The timezone for the project is set to Asia/Tehran:

DB_TIMEZONE=Asia/Tehran
APP_TIMEZONE=Asia/Tehran

The Tehran timezone is GMT+3:30. However, in the app/Helpers/DateHelper.php file, for the fresnsDateTimeByTimezone() method, if the timezone is retrieved, it will return the value 3.5.

This causes an exception when using new DateTimeZone(). For example, Etc/GMT-4 works fine, but Etc/GMT-3.5 will throw an error.

[2024-12-02 14:04:40] production.ERROR: DateTimeZone::__construct(): Unknown or bad timezone (Etc/GMT-3.5) {"exception":"[object] (Exception(code: 0): DateTimeZone::__construct(): Unknown or bad timezone (Etc/GMT-3.5) at /mnt/part1/projects/laravel/contribute/fresns/app/Helpers/DateHelper.php:169)
[stacktrace]
#0 /mnt/part1/projects/laravel/contribute/fresns/app/Helpers/DateHelper.php(169): DateTimeZone->__construct()
#1 /mnt/part1/projects/laravel/contribute/fresns/app/Utilities/DetailUtility.php(1646): App\\Helpers\\DateHelper::fresnsDateTimeByTimezone()
#2 /mnt/part1/projects/laravel/contribute/fresns/app/Utilities/DetailUtility.php(218): App\\Utilities\\DetailUtility::handleUserDate()
#3 /mnt/part1/projects/laravel/contribute/fresns/app/Utilities/DetailUtility.php(84): App\\Utilities\\DetailUtility::userDetail()
#4 /mnt/part1/projects/laravel/contribute/fresns/app/Fresns/Api/Http/Controllers/AccountController.php(172): App\\Utilities\\DetailUtility::accountDetail()
#5 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Routing/Controller.php(54): App\\Fresns\\Api\\Http\\Controllers\\AccountController->login()
#6 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php(43): Illuminate\\Routing\\Controller->callAction()
#7 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Routing/Route.php(265): Illuminate\\Routing\\ControllerDispatcher->dispatch()
#8 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Routing/Route.php(211): Illuminate\\Routing\\Route->runController()
#9 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Routing/Router.php(808): Illuminate\\Routing\\Route->run()
#10 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(144): Illuminate\\Routing\\Router->Illuminate\\Routing\\{closure}()
#11 /mnt/part1/projects/laravel/contribute/fresns/app/Fresns/Api/Http/Middleware/CheckReadOnly.php(32): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#12 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): App\\Fresns\\Api\\Http\\Middleware\\CheckReadOnly->handle()
#13 /mnt/part1/projects/laravel/contribute/fresns/app/Fresns/Api/Http/Middleware/CheckHeaderByWhitelist.php(77): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#14 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): App\\Fresns\\Api\\Http\\Middleware\\CheckHeaderByWhitelist->handle()
#15 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(119): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#16 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Routing/Router.php(807): Illuminate\\Pipeline\\Pipeline->then()
#17 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Routing/Router.php(786): Illuminate\\Routing\\Router->runRouteWithinStack()
#18 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Routing/Router.php(750): Illuminate\\Routing\\Router->runRoute()
#19 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Routing/Router.php(739): Illuminate\\Routing\\Router->dispatchToRoute()
#20 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(201): Illuminate\\Routing\\Router->dispatch()
#21 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(144): Illuminate\\Foundation\\Http\\Kernel->Illuminate\\Foundation\\Http\\{closure}()
#22 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(21): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#23 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ConvertEmptyStringsToNull.php(31): Illuminate\\Foundation\\Http\\Middleware\\TransformsRequest->handle()
#24 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\\Foundation\\Http\\Middleware\\ConvertEmptyStringsToNull->handle()
#25 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(21): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#26 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TrimStrings.php(51): Illuminate\\Foundation\\Http\\Middleware\\TransformsRequest->handle()
#27 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\\Foundation\\Http\\Middleware\\TrimStrings->handle()
#28 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Http/Middleware/ValidatePostSize.php(27): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#29 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\\Http\\Middleware\\ValidatePostSize->handle()
#30 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/PreventRequestsDuringMaintenance.php(110): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#31 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\\Foundation\\Http\\Middleware\\PreventRequestsDuringMaintenance->handle()
#32 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Http/Middleware/HandleCors.php(62): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#33 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\\Http\\Middleware\\HandleCors->handle()
#34 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Http/Middleware/TrustProxies.php(58): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#35 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\\Http\\Middleware\\TrustProxies->handle()
#36 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/InvokeDeferredCallbacks.php(22): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#37 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\\Foundation\\Http\\Middleware\\InvokeDeferredCallbacks->handle()
#38 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(119): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#39 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(176): Illuminate\\Pipeline\\Pipeline->then()
#40 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(145): Illuminate\\Foundation\\Http\\Kernel->sendRequestThroughRouter()
#41 /mnt/part1/projects/laravel/contribute/fresns/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(1190): Illuminate\\Foundation\\Http\\Kernel->handle()
#42 /mnt/part1/projects/laravel/contribute/fresns/public/index.php(17): Illuminate\\Foundation\\Application->handleRequest()
#43 {main}
"}

This PR addresses the issue and allows handling non-rounded timezones.

@ahmadreza1383 ahmadreza1383 force-pushed the fix-datetime-by-timezone branch from 8cee8a8 to 1277b52 Compare December 2, 2024 10:51
@ahmadreza1383 ahmadreza1383 force-pushed the fix-datetime-by-timezone branch from 1277b52 to 137ba88 Compare December 2, 2024 10:52
@jevantang jevantang merged commit 8d17860 into fresns:3.x Dec 2, 2024
1 check passed
@lvsh2012 lvsh2012 mentioned this pull request Apr 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahmadreza1383 @jevantang