Conversation
marhcouto
left a comment
There was a problem hiding this comment.
Sorry for taking so long. Overall ok but tests need further documentation. Moreover, I don't think these were very thought through, we can discuss this tomorrow further
marhcouto
left a comment
There was a problem hiding this comment.
We should talk about most of these comments. Main topics:
- the unit tests are giving me headaches
- a bit better documentation on the integration tests
- the errors mentioned
- not using function (to_ready) every time you can
|
I approved but the steering angle from steering's ID is wrong, it is 0x295D and it is an extended ID. Consult the PR in ROS-CAN if you need to check how it is read |
|
Sorry, I didn't notice this. I changed the id, from what I saw in the other rep, it is normally read so I just changed the id, can you confirm this? |
No description provided.