Will dev customizable shader #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code cleanup
ptsouchlos
requested changes
Feb 1, 2023
Member
ptsouchlos
left a comment
There was a problem hiding this comment.
Thank you for this, this is a really cool shader and a welcome addition to fstl!
With that being said, I'm not the biggest fan of having the preferences in the drawing mode menu.
Could we instead have an option in the View menu, under Draw Mode that shows/hides based on what shader is shown? In the future we can add shader preference support for some of the other shaders as well and make use of similar features.
Contributor
Author
|
Ok, I will look into that :-). |
Added a "Draw Mode Settings" entry in View menu. It is enabled if settings are available for the current draw mode.
Contributor
Author
|
Done. Let me know what you think. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a customizable shader with ambient and directive light.