Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Get rid of compatibility warnings under Ruby 3.4. #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2025
Merged

Get rid of compatibility warnings under Ruby 3.4. #998

merged 1 commit into from
Jan 2, 2025

Conversation

@kewlar
Copy link
Contributor

@kewlar kewlar commented Dec 19, 2024

When running guard 2.19.0 under Ruby 3.4.0rc1, Ruby prints warnings about upcoming incompatibility:

$ guard
~/dev/gems/guard/lib/guard.rb:2: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add logger to your Gemfile or gemspec to silence this warning.
~/dev/gems/guard/bin/_guard-core:11: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
23:57:58 - INFO - Guard::RSpec is running
23:57:58 - INFO - Guard is now watching at '...'

When logger and ostruct gems are explicitly added as dependencies in the guard.gemspec, the warnings are no longer printed:

$ guard
00:01:00 - INFO - Guard::RSpec is running
00:01:00 - INFO - Guard is now watching at '...'

Environment:

Ubuntu Linux 24.04.1 LTS
ruby 3.4.0rc1 (2024-12-12 master 29caae9991) +PRISM [x86_64-linux]
Guard version 2.19.0

Should I add a PR for 2-stable branch?

@rymai
Copy link
Member

rymai commented Jan 2, 2025

Thanks a lot! 🎉

Should I add a PR for 2-stable branch?

I will take care of that, thanks.

@rymai rymai added the 🏠 Housekeeping Non-user facing cleanup and maintenance label Jan 2, 2025
@rymai rymai merged commit 143597c into guard:master Jan 2, 2025
1 check passed
rymai pushed a commit that referenced this pull request Jan 2, 2025
@kewlar @rymai
Chore: get rid of compatibility warnings under Ruby 3.4. (#998)
6d7b917
@ixti ixti mentioned this pull request Jul 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🏠 Housekeeping Non-user facing cleanup and maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kewlar @rymai