Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move should_stop out of the config #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2022
Merged

Move should_stop out of the config #1976

merged 2 commits into from
Jun 2, 2022

Conversation

@shreyamalviya
Copy link
Contributor

@shreyamalviya shreyamalviya commented Jun 2, 2022 •
edited
Loading

What does this PR do?

Fixes #1962

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running a single monkey locally and killing it before the simulation thread starts and while the simulation is running. Tested on GCP with multiple monkeys running on different machines.

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #1976 (d9ce5ba) into develop (7310cc0) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           develop    #1976      +/-   ##
===========================================
- Coverage    56.51%   56.50%   -0.01%     
===========================================
  Files          461      463       +2     
  Lines        12985    12986       +1     
===========================================
  Hits          7338     7338              
- Misses        5647     5648       +1
Impacted Files Coverage Δ
monkey/infection_monkey/config.py 37.73% <ø> (-1.16%) ⬇️
...onkey_island/cc/services/config_schema/internal.py 100.00% <ø> (ø)
monkey/monkey_island/cc/services/node.py 27.77% <0.00%> (ø)
...y/monkey_island/cc/services/infection_lifecycle.py 63.04% <66.66%> (ø)
monkey/monkey_island/cc/models/config.py 100.00% <100.00%> (ø)
monkey/monkey_island/cc/models/monkey.py 91.39% <100.00%> (+0.09%) ⬆️
monkey/monkey_island/cc/services/__init__.py 100.00% <0.00%> (ø)
monkey/monkey_island/cc/services/initialize.py 0.00% <0.00%> (ø)
...ey/monkey_island/cc/repository/IAgentRepository.py
...onkey_island/cc/services/i_file_storage_service.py
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6221a43...d9ce5ba. Read the comment docs.

@shreyamalviya shreyamalviya marked this pull request as ready for review June 2, 2022 07:12
@shreyamalviya shreyamalviya merged commit a1656a7 into develop Jun 2, 2022
@shreyamalviya shreyamalviya deleted the 1962-decouple-should_stop-from-config branch June 2, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilija-lazoroski ilija-lazoroski ilija-lazoroski approved these changes

@VakarisZ VakarisZ VakarisZ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Decouple should_stop/kill/is_dead from the configuration

4 participants

@shreyamalviya @ilija-lazoroski @VakarisZ