Send taps to server without waiting for double tap detection#342
Closed
EtienneMiret wants to merge 6 commits intogujjwal00:masterfrom
Closed
Send taps to server without waiting for double tap detection#342EtienneMiret wants to merge 6 commits intogujjwal00:masterfrom
EtienneMiret wants to merge 6 commits intogujjwal00:masterfrom
Conversation
This test was dependent on the test method execution order. I fix this by ensuring the preferences are reset before each test method.
Contributor
Author
|
Hi @gujjwal00! I see you’ve been working on this lately! Too bad I didn’t send my PR earlier, but 5b4f142 seems me a better solution than this PR. |
Owner
|
Yeah that's the WIP patch I originally worked on some time ago. |
Owner
|
I have merged support for this in 39c387e (also see #224 (comment)) |
Contributor
Author
No problem! We have a working solution, that’s what I wanted 🙂. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
two-left-clicksoption to double tap actions. When this option is selected, taps are immediately sent to server, without waiting for the ~300ms delay needed to detect a double tap.Solves #224