Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[guppy] handle binary-only dependencies #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sunshowers merged 1 commit into from
Nov 28, 2023
Merged

[guppy] handle binary-only dependencies #174

sunshowers merged 1 commit into from
Nov 28, 2023

Conversation

@sunshowers
Copy link
Member

@sunshowers sunshowers commented Nov 28, 2023 •
edited
Loading

Some dependencies don't have lib targets. While they can't be depended on in stable Rust, there's a nightly Rust feature that enables use of binary-only dependencies. In those cases, the resolved_name is an empty string.

Also added mnemos to our corpus.

@sunshowers
[guppy] handle binary-only dependencies
5984d12 
Some dependencies don't have lib targets. While they can't be depended on in
stable Rust, there's a nightly Rust feature that enables use of binary-only
dependencies. In those cases, the `resolved_name` is an empty string.
@sunshowers sunshowers mentioned this pull request Nov 28, 2023
Closed
@sunshowers sunshowers merged commit d1c8e7b into guppy-rs:main Nov 28, 2023
@sunshowers sunshowers deleted the bin-only branch November 28, 2023 21:26
@sunshowers
Copy link
Member Author

sunshowers commented Nov 29, 2023 •
edited
Loading

Note that this isn't a complete fix -- currently we don't have enough information to achieve that. I added this info in a subsequent commit d1e9736

                // This code path is only hit with nightly Rust as of 2023-11. It depends on Rust
                // RFC 3028. at https://github.com/rust-lang/cargo/issues/9096.
                //
                // This isn't quite right -- if we have two or more non-lib dependencies, we'll
                // return true for both of them over here. What we need to do instead is use the
                // extern_name and bin_name fields that are present in nightly DepKindInfo, but that
                // aren't in stable yet. For now, this is the best we can do.
                //
                // (If we're going to be relying on heuristics, it is also possible to use the
                // package ID over here, but that's documented to be an opaque string. It also
                // wouldn't be resilient to patch and replace.)

sunshowers added a commit to nextest-rs/nextest that referenced this pull request Nov 30, 2023
@sunshowers
[meta] update guppy to 0.17.4
2614b1b 
Pick up guppy-rs/guppy#174.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sunshowers