Default 'httpMethod' to 'GET' to Ensure PSR-7 1.6.x Compatibility#167
Open
GuyPaddock wants to merge 1 commit intoguzzle:1.3from
Open
Default 'httpMethod' to 'GET' to Ensure PSR-7 1.6.x Compatibility#167GuyPaddock wants to merge 1 commit intoguzzle:1.3from
GuyPaddock wants to merge 1 commit intoguzzle:1.3from
Conversation
…atibility PSR-7 requires a method to be set on Request objects at the time they are created, but the Operation object previously defaulted the method to an empty string. Now we default it to 'GET', which should be a safe choice. In addition, if a request is misconfigured to force the request method to an empty string, there is now a validation for that. Closes guzzle#166.
0dc7722 to
d14ba44
Compare
This was referenced Aug 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PSR-7 requires a method to be set on Request objects at the time they are created, but the Operation object previously defaulted the method to an empty string. Now we default it to 'GET', which should be a safe choice.
In addition, if a request is mis-configured to force the request method to an empty string, there is now a validation for that.
Closes #166.
(If this should be based off of the
developbranch, per #170, let me know and I will rebase it).