Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-upload-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ jobs:
run: make site

- name: Set up NodeJS
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 22

- name: Generate API docs
run: make apidoc-init apidoc
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/javascript-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node-version: [16]
node-version: [22]
fail-fast: false

steps:
Expand All @@ -28,7 +28,7 @@ jobs:
uses: actions/checkout@v3

- name: Set up NodeJS ${{ matrix.node-version }} on ${{ matrix.os }}
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
Expand All @@ -48,7 +48,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node-version: [16]
node-version: [22]
fail-fast: false

steps:
Expand All @@ -57,7 +57,7 @@ jobs:
uses: actions/checkout@v3

- name: Set up NodeJS ${{ matrix.node-version }} on ${{ matrix.os }}
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
# Use only lowest and highest supported python versions for now,
# to speed up CI runs
python-version: [3.8, "3.12"]
node-version: [16]
node-version: [22]
fail-fast: false

steps:
Expand All @@ -32,7 +32,7 @@ jobs:
cache-dependency-path: 'setup.py'

- name: Set up NodeJS ${{ matrix.node-version }} on ${{ matrix.os }}
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
Expand Down
2 changes: 2 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ Bugfixes & Improvements
- Make 'text' field in 'comments' table NOT NULL and handling data migration (`#1019`_, pkvach)
- Python 3.12 support (`#1015`_, ix5)
- Disable Postbox submit button on click, enable after response (`#993`_, pkvach)
- Document title parameter and improve error handling for /new API (`#1058`_, pkvach)

.. _#951: https://github.com/posativ/isso/pull/951
.. _#967: https://github.com/posativ/isso/pull/967
Expand All @@ -70,6 +71,7 @@ Bugfixes & Improvements
.. _#1019: https://github.com/isso-comments/isso/pull/1019
.. _#1015: https://github.com/isso-comments/isso/pull/1015
.. _#993: https://github.com/isso-comments/isso/pull/993
.. _#1058: https://github.com/isso-comments/isso/pull/1058

0.13.1.dev0 (2023-02-05)
------------------------
Expand Down
Binary file modified isso/js/tests/screenshots/reference/comment.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion isso/js/tests/screenshots/reference/comment.png.hash
Original file line number Diff line number Diff line change
@@ -1 +1 @@
56314990cb566160044f46033a7bd0c4d8be5bb41afa44fa54cf156aed21bbe3
6311b606260c72ad5a27d068e6df9ddb79859a9e36333371abd8765a7f0ef7ba
Binary file modified isso/js/tests/screenshots/reference/postbox.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion isso/js/tests/screenshots/reference/postbox.png.hash
Original file line number Diff line number Diff line change
@@ -1 +1 @@
a218440951dbc7312118647c955d0d4480fc46bb6dddd72e0d9459744b471f32
4061e56d9b4d35836946b95e450bce5f4665973966ec17ddb4f69ea8d74288c8
Binary file modified isso/js/tests/screenshots/reference/thread.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion isso/js/tests/screenshots/reference/thread.png.hash
Original file line number Diff line number Diff line change
@@ -1 +1 @@
a10040e07c4285acea4a36d41ee2ff9877b70fd399d908e6eaf7a4dfad100333
1167f47452855c852b62475f81205eb8bf11cac236b88d72e1c440b3059d6cf1
4 changes: 3 additions & 1 deletion isso/views/comments.py
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,8 @@ def verify(cls, comment):
The comment’s author’s website’s url. Must be Django-conform, i.e. either `http(s)://example.com/foo` or `example.com/`
@apiBody {Number} [parent]
The parent comment’s id if the new comment is a response to an existing comment.
@apiBody {String} [title]
The title of the thread. Required when creating the first comment for a new thread if the title cannot be automatically fetched from the URI.

@apiExample {curl} Create a reply to comment with id 15:
curl 'https://comments.example.com/new?uri=/thread/' -d '{"text": "Stop saying that! *isso*!", "author": "Max Rant", "email": "[email protected]", "parent": 15}' -H 'Content-Type: application/json' -c cookie.txt
Expand Down Expand Up @@ -350,7 +352,7 @@ def new(self, environ, request, uri):
if resp and resp.status == 200:
uri, title = parse.thread(resp.read(), id=uri)
else:
return NotFound(f'URI {uri} does not exist')
return BadRequest(f'Cannot create new thread: URI {uri} is not accessible and no title was provided. Please provide a title parameter in your request.')
else:
title = data['title']

Expand Down
Loading