Add ServiceResolverAwareTrait and ServiceMap attribute #340
Conversation
…r faster service resolution
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| private function searchClassOverAttributes(ReflectionClass $reflectionClass, string $method): ?string | ||
| { | ||
| $attributes = $reflectionClass->getAttributes(Doc::class, ReflectionAttribute::IS_INSTANCEOF); | ||
| $attributes = $reflectionClass->getAttributes(ServiceMap::class, ReflectionAttribute::IS_INSTANCEOF); | ||
|
|
||
| foreach ($attributes as $attribute) { | ||
| /** @var Doc $instance */ | ||
| /** @var ServiceMap $instance */ | ||
| $instance = $attribute->newInstance(); | ||
| if ($instance->method === $method) { | ||
| return $instance->className; |
There was a problem hiding this comment.
Preserve backward compatibility for Doc attributes
The resolver now only inspects #[ServiceMap] attributes and the Doc attribute class was removed entirely. Any existing application using the published #[Doc] attribute will no longer autoload (class not found) and even if the class were available it would be ignored by searchClassOverAttributes, causing runtime failures when resolving services. Consider retaining Doc as a subclass/alias of ServiceMap and checking both attribute names so current users are not broken while migrating.
Useful? React with 👍 / 👎.
🔖 Changes
DocBlockResolverAwareTraitusages with the new cachedServiceResolverAwareTrait#[ServiceMap]attribute