Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@oakrotka
Copy link
Contributor

@oakrotka oakrotka commented Jul 30, 2025

This PR adds the default-fill-shapes option, which makes Satty fill the shapes by default. I also updated the readme to be up to date with the current help output.

@RobertMueller2
Copy link
Collaborator

RobertMueller2 commented Jul 30, 2025

Thank you for the contribution. Other than the readme remarks above, it looks good to me. The lint errors have nothing to do with this PR, we'll address them separately. I'll open an issue for it.

Generally spoken, I know it's tempting to fix all of the readme while editing it anyway. But personally I'd prefer a separate PR for this. Reason being, if we have to revert a PR for whatever reason (not very likely for this one, but generally it's a possibility) we'd lose the readme fixes. You don't need to change this now, just a remark for the future. We have to write this down as contribution guidelines at some point.

@RobertMueller2
Copy link
Collaborator

regarding the readme comments, I think we have copied the help output to the README in the past. Perhaps we need to do that again (and perhaps automate it), and then add the experimental flags with the parameters or the help text.

@oakrotka
Copy link
Contributor Author

Should I revert the changes to the readme (except for the new option), then? I basically just copy-pasted the current help output there, because it changed with the new option and I wanted the readme to be accurate to the new output; fixing stuff broken in previous commits was just a side effect of that

@RobertMueller2
Copy link
Collaborator

Should I revert the changes to the readme (except for the new option), then? I basically just copy-pasted the current help output there, because it changed with the new option and I wanted the readme to be accurate to the new output; fixing stuff broken in previous commits was just a side effect of that

Yeah, I think that would be easiest, thank you.

We'll have to fix the readme in a separate issue.

@RobertMueller2 RobertMueller2 merged commit 3c7f532 into gabm:main Jul 30, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants