Support newlib C library configurations without tm_gmtoff field #2600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newlib C library (https://sourceware.org/newlib/) has a configuration option to add tm_gmtoff field to the tm structure. Not all the platforms supported by newlib enable this option, and spdlog doesn't compile on such platforms due to missing tm_gmtoff field. Fix this by checking for `__NEWLIB__` and `__TM_GMTOFF` and enabling calculate_gmt_offset.
Owner
|
Thanks @igrr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newlib C library has a configuration option to add tm_gmtoff field to the
tmstructure.Not all the platforms supported by newlib enable this option, and spdlog doesn't compile on such platforms due to missing
tm_gmtofffield.This PR fixes this by checking for
__NEWLIB__and__TM_GMTOFFand enablingcalculate_gmt_offset.