Add visualization navigation guard #20881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detects unsaved changes in visualization iframes using DOM observers and event listeners. Shows confirmation when navigating away with unsaved work.
f53c636 to
e982c51
Compare
handle this appropriately. Simplify emits and rely on local change handling.
mvdbeek
reviewed
Sep 9, 2025
|
|
||
| // Monitor DOM changes (skip initial load) | ||
| setTimeout(() => { | ||
| const observer = new MutationObserver(() => markAsChanged()); |
mvdbeek
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20878
Adds navigation guards to prevent users from accidentally losing unsaved work in visualizations like JupyterLite. Implements both Vue Router guards (for in-app navigation) and beforeunload handlers (for browser back/forward/refresh)
How to test the changes?
(Select all options that apply)
License