-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Install Visualization plugins as self-contained packages #20348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Visualization plugins as self-contained packages #20348
Conversation
ea54907 to
fb7940e
Compare
fb7940e to
24ec1e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @guerler! Works well in my local testing, the only thing you may still need to do is adjust the .gitignore file to exclude the installed files.
Co-authored-by: David LΓ³pez <[email protected]>
|
@davelopez thank you so much for the review! |
|
The change seems fine, but I would ask y'all to consider giving your US colleagues a chance to review this during a working day before merging approved requests as the author. IMO the only reason to approve but not merge is to give someone else a chance to review, and this seems like a somewhat important change that we as a team want to agree on ? It's definitely a balance to strike (I sure also like a speedy review process), so I don't think we need to put into the rules, but please consider this in the future. |
|
I appreciate the feedback and understand the concern about timing. In this case, I did not see the change as particularly risky and felt comfortable moving forward after approval, especially since we are still early in the development cycle. That said, I agree it is important to be mindful of our global team and will keep that in mind going forward. I am always happy to follow up if further adjustments are needed. |
This PR introduces a revised mechanism for installing visualization plugins that eliminates the previous split between the Galaxy core repository and the galaxy-visualizations repository. Previously, XML files and logo assets were manually added to the Galaxy core repo, while the actual plugin code was maintained and installed from the galaxy-visualizations repository via npm. This separation can lead to confusion and potential discrepancies between the declared metadata and the functional plugin code. It also makes it cumbersome for administrators who want to add new visualizations. With the revised approach, visualizations are fully self-contained within their npm packages, including all necessary assets such as the XML file and logo file. They are installed directly into Galaxy by specifying the corresponding npm package and version, without requiring any manual intervention or coordination across repositories. This process ensures consistency, reduces maintenance overhead, and simplifies the deployment pipeline. The change is demonstrated here for the
aceeditorandtabulatorvisualization. Moving forward we could introduce a visualization_conf.yml file to allow administrators to explicitly specify the packages and versions to be installed without having to touch the gulp file.How to test the changes?
(Select all options that apply)
License