Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Default hubVersion for ubuntu hub image bumped from 3.4.2-beta.1 to 3.4.2 #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webbertakken merged 1 commit into from
May 7, 2023
Merged

Default hubVersion for ubuntu hub image bumped from 3.4.2-beta.1 to 3.4.2 #211

webbertakken merged 1 commit into from
May 7, 2023

Conversation

@Jendoliver
Copy link
Contributor

@Jendoliver Jendoliver commented May 4, 2023 •
edited
Loading

Changes

I tested recreating the android image on my end with this version of the Unity Hub and I could successfully build an .apk for a game that is using Unity 2022.2.17f1, and was failing with the old image. I also explicitly checked for the OpenJDK version downloaded by Unity Hub for this Unity version, and it is correct:

/opt/unity/Editor/Data/PlaybackEngines/AndroidPlayer/OpenJDK/bin/java -version
openjdk version "11.0.14.1" 2022-02-08
OpenJDK Runtime Environment Temurin-11.0.14.1+1 (build 11.0.14.1+1)
OpenJDK 64-Bit Server VM Temurin-11.0.14.1+1 (build 11.0.14.1+1, mixed mode)

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (not needed)

Please tell me if something else is expected from my side, as this is my first pull request here and I might be missing something 😄 And I also want to seize the opportunity to thank you one thousand times for this amazing project!

@github-actions
Copy link

github-actions bot commented May 4, 2023

Cat Gif

@AndrewKahr
Copy link
Member

AndrewKahr commented May 4, 2023

While I certainly agree that the beta version should be switched to a stable version, I am curious about what you mean by the current images don't work as I am currently using the images to build Android and it appears to work fine.

@webbertakken
Copy link
Member

webbertakken commented May 4, 2023

Thanks a lot for your contribution @Jendoliver. And happy the project is helpful to you!

Like Andrew I also suspect the fix was already done using that beta version and this PR just moves it to stable.

webbertakken
webbertakken approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@webbertakken webbertakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way, LGTM

@Jendoliver
Copy link
Contributor Author

Jendoliver commented May 5, 2023 •
edited
Loading

Sorry, you are both completely right since my test was flawed: I didn't build an image from the repo source (with the beta version of the hub) to try to reproduce the error, I only did it with my change and tested if that fixed my problem. Instead I relied on my CI logs which I just saw were using an old game ci version (1.0.1). Since the Android issues were still open I just assumed the problem still existed instead of doing a proper test 🙏

I just pulled unityci/editor:ubuntu-2022.2.11f1-android-1.1.2 and indeed the issue is fixed there already. So thanks for taking the time to answer and for the fast review!

@webbertakken webbertakken merged commit 3bad88c into game-ci:main May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webbertakken webbertakken webbertakken approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unity 2022.2 Android JDK not found JDK not found

3 participants

@Jendoliver @AndrewKahr @webbertakken