Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix windows builds #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webbertakken merged 1 commit into from
Jul 4, 2025
Merged

Fix windows builds #256

webbertakken merged 1 commit into from
Jul 4, 2025

Conversation

@alimalkhalifa
Copy link
Contributor

@alimalkhalifa alimalkhalifa commented Jul 4, 2025 •
edited by coderabbitai bot
Loading

Changes

  • Remove MSVCP120.ddl and MSVCR120.dll from unityci/editor:windows-* Dockerfile

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)

Summary by CodeRabbit

  • Chores
    • Updated Windows Unity editor image to no longer include certain DLL dependencies.

@alimalkhalifa
Remove from unityci/editor:windows-* Dockerfile buildstep copying
95dcd41 
MSVCP120.ddl and MSVCR120.dll as leading to errors
@coderabbitai
Copy link

coderabbitai bot commented Jul 4, 2025 •
edited
Loading

Walkthrough

The Dockerfile for the Windows Unity editor image was updated to stop copying the MSVCP120.dll and MSVCR120.dll files from the builder stage to the final image, while still copying MSVCP100.dll and MSVCR100.dll. No other modifications were made.

Changes

File(s) Change Summary
images/windows/editor/Dockerfile Removed copying of MSVCP120.dll and MSVCR120.dll dependencies.

Poem

In Docker’s den, two DLLs said goodbye,
The 120s left, while 100s still fly.
A lighter build, a tidier scene,
The editor’s image, now more lean.
With every hop, the rabbit grins—
For tidy code is where joy begins! 🐇

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d227be and 95dcd41.

📒 Files selected for processing (1)
  • images/windows/editor/Dockerfile (0 hunks)
💤 Files with no reviewable changes (1)
  • images/windows/editor/Dockerfile

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented Jul 4, 2025

Cat Gif

@webbertakken
Copy link
Member

webbertakken commented Jul 4, 2025

Any explanation of your rationale behind these removals would be great :)

@alimalkhalifa alimalkhalifa marked this pull request as ready for review July 4, 2025 15:43
@alimalkhalifa
Copy link
Contributor Author

alimalkhalifa commented Jul 4, 2025

Hi @webbertakken thanks for coming back so quickly!

If you see https://github.com/game-ci/docker/actions/runs/16075733917 you will find in the logs that the DLLs are missing.

I have replicated this locally. Built up from the Dockerfile and found that I was missing those files in the Builder image.

I have then taken them out and rebuilt, which succeeded. I did a test build of my own game via IL2CPP and found no errors.

@webbertakken
Copy link
Member

webbertakken commented Jul 4, 2025

That makes sense.

It makes me wonder if these were ever needed. I think they might have been in the past at least.

Either way, happy to iterate and move it forward

@alimalkhalifa
Copy link
Contributor Author

alimalkhalifa commented Jul 4, 2025

Hello!

Is it normal for the ios 2023.1.20f1 to fail? I did not touch anything on the ios Dockerfiles

@webbertakken webbertakken merged commit ac1df6a into game-ci:main Jul 4, 2025
176 of 177 checks passed
@leo14s leo14s mentioned this pull request Dec 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webbertakken webbertakken webbertakken approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alimalkhalifa @webbertakken