forked from kubernetes/autoscaler
-
Notifications
You must be signed in to change notification settings - Fork 29
Sync upstream v1.33.0 #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aaronfern
merged 3,028 commits into
gardener:machine-controller-manager-provider
from
thiyyakat:sync-upstream-v1.33.0
Aug 14, 2025
Merged
Sync upstream v1.33.0 #355
aaronfern
merged 3,028 commits into
gardener:machine-controller-manager-provider
from
thiyyakat:sync-upstream-v1.33.0
Aug 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix 2 bugs in the OCI integration
Improve resilience of diskTypes requests.
Remove outdated GCE cloudprovider owners
…intsTesting Add unit test for cleaning deletion soft taint in scale down cool down
Also consider containerStatus.resources when handling container resources
…y-sts-to-drain Allow draining when StatefulSet kind has custom API Group
…ller This commit instruments the `observer`, used within the `recommender` e2e tests, reuse the test framework namespace. The main reason behind this change is to allow running the test suite against an existing cluster that already has `VPA` resources in other namespaces. Currently, the test is considering all `namespaces` when it builds it's `observer`'s controller, which makes the test fail when trying to validate the recommendations for components outside of the test scope. This behavior was discovered while running the e2e tests against a cluster with VPA setup that uses Prometheus as history storage provider.
…bserver-reuse-test-framework-namespace e2e(recommender): Restrict the internal `VPA` controller scope to test namespace
…-metric Emit scale down metric even when there is no scale down candidates.
…caleDownInCooldown signature.
…down-signature Patch TestCleaningSoftTaintsInScaleDown to be compatible with new isScaleDownInCooldown signature
aaronfern
reviewed
Jul 29, 2025
|
@unmarshall You have pull request review open invite, please check |
aaronfern
reviewed
Aug 6, 2025
aaronfern
approved these changes
Aug 7, 2025
Member
aaronfern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
/lgtm
aaronfern
reviewed
Aug 14, 2025
Co-authored-by: Aaron Francis Fernandes <[email protected]>
aaronfern
approved these changes
Aug 14, 2025
0fdfec8
into
gardener:machine-controller-manager-provider
10 of 11 checks passed
thiyyakat
added a commit
to thiyyakat/autoscaler
that referenced
this pull request
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/second-opinion
Needs second review by someone else
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #351, partially fixes MCM Issue #982
Special notes for your reviewer:
Release note: