Add labels to BasicIgnoredLabels to fix similarity check #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfern
reviewed
Sep 16, 2025
| // LabelTopologyDiskCSIAzure is a CSI-specific label for disk driver in Azure. | ||
| LabelTopologyDiskCSIAzure = "topology.disk.csi.azure.com/zone" | ||
| // LabelAWSZoneID indicates the zone-id of the node in AWS | ||
| LabelAWSZoneID = "topology.k8s.aws/zone-id" |
Member
There was a problem hiding this comment.
Suggested change
| LabelAWSZoneID = "topology.k8s.aws/zone-id" | |
| LabelTopologyAWSZoneID = "topology.k8s.aws/zone-id" |
Consider changing this var (feel free to use something different if you have more ideas) for uniformity as other labels around topology seem to follow it
Comment on lines
45
to
46
| // LabelMachineName adds the name of the machine to the node | ||
| LabelMachineName = "node.gardener.cloud/machine-name" |
Member
There was a problem hiding this comment.
Nit: Please move this label to be above all cloud provider labels
6e805c8
into
gardener:machine-controller-manager-provider
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes a bug which made CA treat similar node groups as dissimilar, resulting in imbalanced scale ups across zones. The PR adds the following labels to
BasicIgnoredLabels:The values for these labels will be ignored during the similarity check. Hence, two node templates with differing values for these labels can still be considered "similar" if other similarity checks pass.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Unit tests and integration tests (aws) passed.
Release note: