Added diagnostic logs for potential empty nodes #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiyyakat
reviewed
Oct 21, 2025
| if skipMirrorPods && podutils.IsMirrorPod(podInfo.Pod) { | ||
| daemonSetAndMirrorPodsUtilization.Add(resourceValue) | ||
| if detailedPodCount < maxDiagnosticPods { | ||
| fmt.Fprintf(&diagBuff, "pod %s/%s is a miror pod. Adding resource %q, value %v to daemonSetAndMirrorPodsUtilization\n", podInfo.Pod.Namespace, podInfo.Pod.Name, resourceName, resourceValue) |
Member
There was a problem hiding this comment.
Suggested change
| fmt.Fprintf(&diagBuff, "pod %s/%s is a miror pod. Adding resource %q, value %v to daemonSetAndMirrorPodsUtilization\n", podInfo.Pod.Namespace, podInfo.Pod.Name, resourceName, resourceValue) | |
| fmt.Fprintf(&diagBuff, "pod %s/%s is a mirror pod. Adding resource %q, value %v to daemonSetAndMirrorPodsUtilization\n", podInfo.Pod.Namespace, podInfo.Pod.Name, resourceName, resourceValue) |
Nitpick: typo: miror --> mirror
|
|
||
| podsRequest.Add(resourceValue) | ||
| if detailedPodCount < maxDiagnosticPods { | ||
| fmt.Fprintf(&diagBuff, "pod %s/%s has requests %v\n", podInfo.Pod.Namespace, podInfo.Pod.Name, resourceValue) |
Member
There was a problem hiding this comment.
Any reason why resource name is only logged for mirror and daemonset pods?
Member
Author
There was a problem hiding this comment.
This was a miss. Corrected the log message
f730f6f to
4d4bc50
Compare
7bbbe4c
into
gardener:machine-controller-manager-provider
15 checks passed
aaronfern
added a commit
to aaronfern/autoscaler
that referenced
this pull request
Oct 21, 2025
aaronfern
added a commit
to aaronfern/autoscaler
that referenced
this pull request
Oct 21, 2025
aaronfern
added a commit
to aaronfern/autoscaler
that referenced
this pull request
Oct 21, 2025
aaronfern
added a commit
that referenced
this pull request
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds diagnostic logs to the function
CalculateUtilizationOfResource()This was needed due to recent occurrences where CA found nodes with 0% resource utilisation even though pods were scheduled on such nodes
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: