Check for color support whether printing colored sentences. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for color support whether printing colored sentences. Also changed print functions name to match PIP8 pattern (https://www.python.org/dev/peps/pep-0008/#function-names)
Owner
|
Thanks a lot @Plinio89s for letting me know this and for the PR 👍 😄 |
Author
|
My pleasure! |
Owner
|
@Plinio89s Yes i am still configuring it |
Owner
|
@Plinio89s i lost color on windows 10, Windows 10 supports colors: BeforeAfterany idea on how to fix it? |
Author
|
I noticed this side effect. I tried to find a solution but I couldn't, so I let the code exactly as it is in django. i.e. on windows terminal always shows without color. (Of course if this side effect bothers you, I won't be sad if you take the code away.) :) |
Owner
|
@Plinio89s i think i can detect windows version and set it back... Thank you... |
gautamkrishnar
added a commit
that referenced
this pull request
Jun 25, 2016
Owner
|
Fixed that issue 😄 @Plinio89s |
gautamkrishnar
added a commit
that referenced
this pull request
Jun 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for color support whether printing colored sentences.
Also changed print functions name to match PIP8 pattern
(https://www.python.org/dev/peps/pep-0008/#function-names)