This repository was archived by the owner on Jun 6, 2025. It is now read-only.
Gh-3125: GafferPopGraph should catch certain exceptions #3133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3133 +/- ##
=============================================
+ Coverage 66.01% 66.02% +0.01%
- Complexity 2514 2515 +1
=============================================
Files 909 909
Lines 29024 29025 +1
Branches 3226 3226
=============================================
+ Hits 19160 19164 +4
+ Misses 8428 8426 -2
+ Partials 1436 1435 -1 ☔ View full report in Codecov by Sentry. |
library/tinkerpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopGraph.java
Outdated
Show resolved
Hide resolved
library/tinkerpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopGraphIT.java
Outdated
Show resolved
Hide resolved
GCHQDeveloper314
approved these changes
Dec 12, 2023
rj77259
suggested changes
Dec 14, 2023
library/tinkerpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopGraph.java
Show resolved
Hide resolved
t92549
approved these changes
Dec 18, 2023
tb06904
approved these changes
Dec 19, 2023
rj77259
approved these changes
Dec 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the try/catch to catch all exceptions and added a test that it catches any invalid operation chains.