This repository was archived by the owner on Jun 6, 2025. It is now read-only.
Gh-283: Make CollectionContains::test support null #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is just failing on copyright headers being out of date, and it explains what is wrong in the GitHub ci output. |
Make the `CollectionContains.test` function return `false` on a null input, instead of throwing a `NullPointerException`.
6296c23 to
805a83e
Compare
|
|
|
@t92549 I ran the |
Codecov Report
@@ Coverage Diff @@
## develop #284 +/- ##
=============================================
+ Coverage 81.13% 82.08% +0.95%
- Complexity 1534 1616 +82
=============================================
Files 185 194 +9
Lines 4268 4316 +48
Branches 430 435 +5
=============================================
+ Hits 3463 3543 +80
+ Misses 627 592 -35
- Partials 178 181 +3
Continue to review full report at Codecov.
|
t92549
approved these changes
Oct 13, 2022
|
@derlin Thanks again for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
CollectionContains.testfunction returnfalseon a null input, instead of throwing aNullPointerException.Fixes #283.